search

go-coldbrew / cookiecutter-coldbrew

A cookiecutter template to build golang services powered by ColdBrew
MIT License
4 stars 1 forks source link

Health check and ready check are unnecessary #9

Closed intel352 closed 5 months ago

intel352 commented 1 year ago

gRPC in Go already provides a built-in health check which can also be used for your readiness check. https://pkg.go.dev/google.golang.org/grpc/health

I'm referring to your definition of custom rpc endpoints for health/readiness. https://github.com/go-coldbrew/cookiecutter-coldbrew/blob/c54fcc2811a20bdfb7a58c46544d13e31a007331/%7B%7Bcookiecutter.app_name%7D%7D/proto/%7B%7Bcookiecutter.app_name%7Clower%7D%7D.proto#L34

ankurs commented 1 year ago

Hey @intel352 Thanks for the bug, we have since moved to these custom definition

let me know if you feel this still needs to be addressed