search

go-cq / cq

neo4j cypher library for database/sql in go
MIT License
133 stars 11 forks source link

Properly handle escaped chars #22

Closed johnnadratowski closed 9 years ago

johnnadratowski commented 9 years ago

@wfreeman

I'm using this library for a Neo project I have. I found this issue with escaped characters in string literals. Pretty simple fix. I'd appreciate it if we could get this into v1 as soon as we can, as it's causing some issues for my project.

Thanks!

johnnadratowski commented 9 years ago

@wfreeman - I think the test not passing is a fluke, I was able to run these tests successfully.

 ➜  go test -covermode=count -coverprofile=../typescov.out
OK: 32 passed, 1 skipped
PASS
coverage: 77.9% of statements
ok      gopkg.in/cq.v1  18.489s
freeeve commented 9 years ago

indeed, it seems like it failed to set the test password in the build process. thanks for the PR!

freeeve commented 9 years ago

the weird thing is it continues to happen. there may be a timing problem between neo4j start and the curl.

johnnadratowski commented 9 years ago

@wfreeman woohoo! Thanks for the quick reply and merge! :+1: