search

go-debos / debos-recipes

Collection of debos recipes
Apache License 2.0
47 stars 24 forks source link

debian/armhf/image-wb/debimage-wb.yaml repair #14

Closed stappersg closed 1 year ago

stappersg commented 4 years ago

The build error was mkimage not found. Installed it from u-boot-tools, but it needs to be in the chroot

Please note: It is now a clean build. It is NOT verified on actual hardware (I didn't have access to it when the build errors was (and repaired))

obbardc commented 4 years ago

what is the purpose of the two chroot: true additions ?

stappersg commented 4 years ago

Just adding package u-boot-tools was not enough to repair the build error I did encounter. chroot: true was also needed. I got inspiration from lines like https://github.com/go-debos/debos-recipes/blob/74b259326815a0af699115c8847104250e4c60cc/debian/armhf/image-wb/debimage-wb.yaml#L17 and https://github.com/go-debos/debos-recipes/blob/74b259326815a0af699115c8847104250e4c60cc/debian/armhf/image-wb/debimage-wb.yaml#L28

obbardc commented 4 years ago

You should probably install u-boot-tools on the host, the original script would have work then :-) I'm not sure if it makes sense to add this package into the image, in my experience most of the time the u-boot script is generated on the host anyway.

Maybe it would be worth adding this as a note in the wandboard README ?

stappersg commented 4 years ago

This pull request now waits either

and while waiting those this PR documents these observations.

P.S. Thanks for

I'm not sure if it makes sense to add u-boot-tools package into the image,

andhe commented 4 years ago

This pull request now waits either [...]

  • for me checking the You should probably install u-boot-tools on the host advice [...]

As the original author of this recipe I can confirm that this was my intention. The reason to use the tool on the host (outside the chroot) is to avoid installing something in the target system that is only needed during image production (and not on the actual target system).

A possible alternative to avoid this implicit dependency on the host system would be to merge your changes with the addition that the u-boot-tools is again purged once it is no longer needed. It is probably a better idea to just document somewhere appropriate which tools are supposed to be available on the host for each recipe though.