search

go-debos / debos

Debian OS builder
Apache License 2.0
540 stars 138 forks source link

Add option to quiet fakemachine #478

Closed bergmx closed 9 months ago

bergmx commented 9 months ago

Hi! Thanks for the work on this useful project.

We have successfully been using debos for some time, but it always prints the whole debos invocation, which causes secrets passed into debos as variables (e.g. account passwords, private keys) to be written to our CI logs. I looked into this and found that it was because fakemachine logs the command it runs by default, though it has an option to suppress this. I saw no way of setting this option through debos, though, hence this pull request.

This pull request adds the flag "--quiet-fakemachine" because it was the least intrusive change, but on a second thought, it looks a bit odd. I think it might make more sense to use the quiet option in fakemachine by default, and let the existing debos flag "--verbose" disable it instead. What do you think? Any approach that lets us pass a variable without having it written to log is fine with us.

obbardc commented 9 months ago

@bergmx Thanks for this, I think i'd rather disable the fakemachine invocation log message by default (e.g. SetQuiet(false)) & instead enable it with debos --verbose.

It may be nicer to disable the message by default and have --verbose and machine.SetVerbose(true|false) on the fakemachine side, but that is hindsight ;-).

bergmx commented 9 months ago

Sounds good to me! I made new commit with that change.

bergmx commented 9 months ago

Hi again @obbardc ! Looks like the merge is blocked. I can't see anything I can do on my end, so maybe there's a button to press on your end? Let me know if there is something I have to do.

obbardc commented 9 months ago

I had to review it again manually! Should be all done now though. Thanks again for your contribution!