go-debos / debos

Debian OS builder
Apache License 2.0
540 stars 138 forks source link

actions: Fix regression introduced with FAT{12|16|32} support. #499

Closed azayet01 closed 5 months ago

azayet01 commented 5 months ago

The regression was introduced with the following commit :

commit 94fedb2c0c8a97ceb7c9b153aefa81c8d94ce57b
Author: Christopher Obbard <chris.obbard@collabora.com>
Date:   Tue Mar 19 17:43:42 2024 +0000
actions: image-partition: enable creation of FAT{12|16|32} partitions

This one added more options when it comes to creating FAT partitions. So when partition fs is defined as "fat", "fat12", "fat16", "fat32", "msdos" or "vfat", then mkfs.vfat is used to create the partition, and different options were used depending on the FAT type.

The main issue is that mounting a FAT partition should use "vfat" as fs type when using syscall.Mount().

So, in order to fix this issue, "vfat" is simply used to mount "fat", "fat12", "fat16", "fat32" or "msdos" partitions.