search

go-debos / debos

Debian OS builder
Apache License 2.0
533 stars 136 forks source link

actions: fix fstab generated in case of FAT{12|16|32}. #501

Closed azayet01 closed 3 months ago

azayet01 commented 3 months ago

Recent changes introduced a tuned formatting of the partitions created with FAT{12|16|32}. The issue is that fstab is generated using the fs property which won't match the system expectations.

If the fs property is "fat", "fat12", "fat16", "fat32" or "msdos", then fstab must use "vfat".

obbardc commented 3 months ago

Thank you for this fix!

azayet01 commented 3 months ago

@obbardc , You are welcome ! thanks for reviewing and reacting fast ! Very much appreciated. There are the two critical stuff that I have. But for the remaining contribution , it's not critical so I will be pushing some proposals but not critical to have.

Have a great day !

obbardc commented 3 months ago

@azayet01 Please feel free to open issues/PRs about anything you wish to discuss :-). Thank you again for your contributions!