Using "--memory" breaks fakemachine backend

go-debos / debos

Debian OS builder

Apache License 2.0

533 stars 136 forks source link

Using "--memory" breaks fakemachine backend #509

Open tboehler1 opened 2 months ago

tboehler1 commented 2 months ago

Some time in the last 2 months I've been unable to use debos with the "--memory" flag. The fakemachine backend keeps running into OOM errors, hangs completely, and times out after a few minutes.

To reproduce:

$ cat repro.yaml
architecture: arm64

actions:
  - action: run
    command: "echo 'Hello World'"

Run this using debos --memory 8192 repro.yaml

Outputs:

debos --memory 8192 repro.yaml
debos --show-boot --verbose --memory 8192 repro.yaml

flxzt commented 2 months ago

Did you try using 8192MB ? Without a unit I think it parses as only 8192 bytes (see here)

tboehler1 commented 2 months ago

That was indeed the problem and when specifying 8192MB it works. Sorry for the noise!

obbardc commented 2 months ago

I created https://github.com/go-debos/debos/pull/510 to hopefully warn when a user forgets to add a suffix and not change existing behaviour. :-)