cmd/dlv: improve positional argument completion

go-delve / delve

Delve is a debugger for the Go programming language.

MIT License

22.84k stars 2.14k forks source link

cmd/dlv: improve positional argument completion #3699

Closed scop closed 5 months ago

scop commented 5 months ago

Avoid default filename completions when not applicable.

aarzilli commented 5 months ago

See the test failures, for example.

scop commented 5 months ago

Does not seem cobra handles -- for us re max number of args. Narrowed the PR down to just completion improvements (some of which aren't quite perfect regarding also --, but should be improvements over current state anyway).