search

go-delve / delve

Delve is a debugger for the Go programming language.
MIT License
23.01k stars 2.14k forks source link

Incomplete vendoring of dependencies #481

Closed ascandella closed 8 years ago

ascandella commented 8 years ago

I'm packaging delve for our private debian mirror so the tool is available on our machines. I noticed you are vendor-ing dependencies (which is good), but they seem incomplete. Specifically, when I do a clean build, it seems like not all of the required source is available.

I worked around this by doing a godep save ./... and committing the result to our internal git mirror where we build debians from.

  1. What version of Delve are you using (dlv version)? I pulled the HEAD of master today, 53af850bdc8e2db73ea64d02255e4ae4d1b97343)
  2. What version of Go are you using? (go version)? 1.5 and 1.6
  3. What operating system and processor architecture are you using? Debian Jessie Linux
  4. What did you do? Ran git-buildpackage (after creating debian files)
  5. What did you expect to see? Successful package build
  6. What did you see instead? Missing dependencies. Here are the packages that were added when I re-vendored myself:
+           "ImportPath": "github.com/BurntSushi/toml",
+           "ImportPath": "github.com/armon/consul-api",
+           "ImportPath": "github.com/coreos/go-etcd/etcd",
            "ImportPath": "github.com/cpuguy83/go-md2man/md2man",
+           "ImportPath": "github.com/davecgh/go-spew/spew",
            "ImportPath": "github.com/davecheney/profile",
+           "ImportPath": "github.com/hashicorp/hcl",
+           "ImportPath": "github.com/hashicorp/hcl/hcl/ast",
+           "ImportPath": "github.com/hashicorp/hcl/hcl/parser",
+           "ImportPath": "github.com/hashicorp/hcl/hcl/scanner",
+           "ImportPath": "github.com/hashicorp/hcl/hcl/strconv",
+           "ImportPath": "github.com/hashicorp/hcl/hcl/token",
+           "ImportPath": "github.com/hashicorp/hcl/json/parser",
+           "ImportPath": "github.com/hashicorp/hcl/json/scanner",
+           "ImportPath": "github.com/hashicorp/hcl/json/token",
            "ImportPath": "github.com/inconshreveable/mousetrap",
+           "ImportPath": "github.com/kr/pretty",
+           "ImportPath": "github.com/kr/text",
+           "ImportPath": "github.com/magiconair/properties",
+           "ImportPath": "github.com/mitchellh/mapstructure",
            "ImportPath": "github.com/peterh/liner",
+           "ImportPath": "github.com/pmezard/go-difflib/difflib",
            "ImportPath": "github.com/russross/blackfriday",
+           "ImportPath": "github.com/spf13/cast",
            "ImportPath": "github.com/spf13/cobra",
+           "ImportPath": "github.com/spf13/cobra/cobra",
+           "ImportPath": "github.com/spf13/cobra/cobra/cmd",
+           "ImportPath": "github.com/spf13/cobra/doc",
+           "ImportPath": "github.com/spf13/jwalterweatherman",
            "ImportPath": "github.com/spf13/pflag",
+           "ImportPath": "github.com/spf13/viper",
+           "ImportPath": "github.com/spf13/viper/remote",
+           "ImportPath": "github.com/stretchr/testify/assert",
+           "ImportPath": "github.com/ugorji/go/codec",
+           "ImportPath": "github.com/xordataexchange/crypt/backend",
+           "ImportPath": "github.com/xordataexchange/crypt/backend/consul",
+           "ImportPath": "github.com/xordataexchange/crypt/backend/etcd",
+           "ImportPath": "github.com/xordataexchange/crypt/config",
+           "ImportPath": "github.com/xordataexchange/crypt/encoding/secconf",
+           "ImportPath": "golang.org/x/crypto/cast5",
+           "ImportPath": "golang.org/x/crypto/openpgp",
+           "ImportPath": "golang.org/x/crypto/openpgp/armor",
+           "ImportPath": "golang.org/x/crypto/openpgp/elgamal",
+           "ImportPath": "golang.org/x/crypto/openpgp/errors",
+           "ImportPath": "golang.org/x/crypto/openpgp/packet",
+           "ImportPath": "golang.org/x/crypto/openpgp/s2k",
            "ImportPath": "golang.org/x/debug/dwarf",
+           "ImportPath": "gopkg.in/fsnotify.v1",
            "ImportPath": "gopkg.in/yaml.v2",
ascandella commented 8 years ago

Hmm actually, it looks like I was trying to build more than just the dlv command. When I restrict the debian to only that target, everything works fine.