feature: configurable logging

go-ego / riot

Go Open Source, Distributed, Simple and efficient Search Engine; Warning: This is V1 and beta version, because of big memory consume, and the V2 will be rewrite all code.

Apache License 2.0

6.11k stars 474 forks source link

feature: configurable logging #80

Open bobheadxi opened 5 years ago

bobheadxi commented 5 years ago

Ego version (or commit ref): cd980ec

right now the library logs wherever it wants, which is rather annoying because:

if we have our own logging framework, standard out is now polluted by logs formatted differently
logs cannot be silenced, so in tests we have a nice mess of output from riot whenever a test fails

proposal:

accept a minimal logger interface in Engine configuration
provide a no-op logger by default

bobheadxi commented 5 years ago

@vcaesar I'd be willing to put in a PR to implement this

stuchilde commented 3 years ago

Did you resolved it?

bobheadxi commented 3 years ago

I ended up migrating to https://github.com/blevesearch/bleve, which IMO is a nicer library and supports setting a custom logger