search

go-ego / riot

Go Open Source, Distributed, Simple and efficient Search Engine; Warning: This is V1 and beta version, because of big memory consume, and the V2 will be rewrite all code.
Apache License 2.0
6.11k stars 473 forks source link

align the way to calculate hash #94

Open Ksloveyuan opened 5 years ago

Ksloveyuan commented 5 years ago

The pull request will be closed without any reasons if it does not satisfy any of following requirements:

  1. Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
  2. Please read contributing guidelines: CONTRIBUTING
  3. Describe what your pull request does and which issue you're targeting (if any and Please use English)
  4. ... if it is not related to any particular issues, explain why we should not reject your pull request.
  5. The Commits must use English, must be test and No useless submissions.

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

Description

The hash is used in segment.go line 260 to calculate shard index, rigth?

As calculate hash by both docid and content, if the content changes a bit then update the same docid's index, it will be highly possible assigned to another shard, so that there will be duplicated search result with same docid, which is not expected.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.