search

go-enry / go-license-detector

Reliable project licenses detector.
Other
127 stars 36 forks source link

go: update to version 1.18 #33

Closed KarthikNayak closed 1 year ago

KarthikNayak commented 1 year ago

Go only supports -2 major versions. Currently we're on Go 1.20, so the last supported version is 1.18.

Let's update the library from Go 1.17 to Go 1.18

KarthikNayak commented 1 year ago

@bzz could you have a look at this? Also seems like a release is due, maybe after this?

CC @kuba-- @mcuadros

KarthikNayak commented 1 year ago

@bzz could you have a look at this? Also seems like a release is due, maybe after this?

CC @kuba-- @mcuadros

@kuba-- could you please help merge this and create a new release version?

kuba-- commented 1 year ago

@bzz could you have a look at this? Also seems like a release is due, maybe after this? CC @kuba-- @mcuadros

@kuba-- could you please help merge this and create a new release version?

I can merge it, because I do not see any risk in the PR, but I think the right person to tag a new release is @bzz

kuba-- commented 1 year ago

@bzz , @KarthikNayak I've just saved a new release draft v4.3.1 https://github.com/go-enry/go-license-detector/releases/tag/untagged-aee74b862800a31bae9e

KarthikNayak commented 1 year ago

Thank you @kuba-- , waiting on this release since we also want to use the changes from https://github.com/go-enry/go-license-detector/commit/bae4e828d6ff4bb0b84dadc957a3a822149cdda5.

Any idea when this will draft will be released? (The draft is private btw, I cannot access it).

kuba-- commented 1 year ago

I've published as a Pre-release, so should be available. PTAL