search

go-errors / errors

errors with stacktraces for go
https://godoc.org/github.com/go-errors/errors
MIT License
921 stars 93 forks source link

Functions Join and Unwrap #42

Closed lovromazgon closed 1 year ago

lovromazgon commented 1 year ago

Similar to how this library already provides As and Is, it would be nice also to provide Join and Unwrap, simply by delegating to the stdlib implementations. This way there would no longer be a need to import stdlib errors and we could avoid the naming conflict when both packages are imported.

Let me know if you would consider adding this, I can open a PR.

ConradIrwin commented 1 year ago

Absolutely, please do!

On Wed, Aug 30 2023 at 06:53, Lovro Mažgon @.***> wrote:

Similar to how this library already provides As and Is, it would be nice also to provide Join https://pkg.go.dev/errors#Join and Unwrap https://pkg.go.dev/errors#Unwrap, simply by delegating to the stdlib implementations. This way there would no longer be a need to import stdlib errors and we could avoid the naming conflict when both packages are imported.

Let me know if you would consider adding this, I can open a PR.

— Reply to this email directly, view it on GitHub https://github.com/go-errors/errors/issues/42, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXAQBQACQA4KCCDFSWNFLXX5AWLANCNFSM6AAAAAA4ER7SQE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lovromazgon commented 1 year ago

@ConradIrwin do you plan to create a release anytime soon? We'd like to use it, although it would be nice if we could pin the dependency to a proper version.

ConradIrwin commented 1 year ago

@ConradIrwin https://github.com/ConradIrwin do you plan to create a release anytime soon? We'd like to use it, although it would be nice if we could pin the dependency to a proper version.

Sorry for the delay, 1.5.0 is hot off the press!

On Wed, Sep 06, 2023 at 5:19 AM, Lovro Mažgon @.***> wrote:

@ConradIrwin https://github.com/ConradIrwin do you plan to create a release anytime soon? We'd like to use it, although it would be nice if we could pin the dependency to a proper version.

— Reply to this email directly, view it on GitHub https://github.com/go-errors/errors/issues/42#issuecomment-1708151205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXAQB6DWIO7FBOW5D5NVDXZBL5JANCNFSM6AAAAAA4ER7SQE . You are receiving this because you were mentioned.Message ID: @.***>

lovromazgon commented 1 year ago

Thank you!