go-faker / faker

Go (Golang) Fake Data Generator for Struct, previously https://github.com/bxcodec/faker
https://pkg.go.dev/github.com/go-faker/faker/v4
MIT License
658 stars 31 forks source link

fix: tolower domain by default #32

Closed rfyiamcool closed 1 year ago

rfyiamcool commented 1 year ago

summary

I think a lowercase domain name would be better.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f70bf73) 89.04% compared to head (7bce56e) 89.04%. Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32 +/- ## ======================================= Coverage 89.04% 89.04% ======================================= Files 12 12 Lines 1762 1762 ======================================= Hits 1569 1569 Misses 138 138 Partials 55 55 ``` | [Files Changed](https://app.codecov.io/gh/go-faker/faker/pull/32?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [internet.go](https://app.codecov.io/gh/go-faker/faker/pull/32?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-aW50ZXJuZXQuZ28=) | `80.26% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.