search

go-faker / faker

Go (Golang) Fake Data Generator for Struct, previously https://github.com/bxcodec/faker
https://pkg.go.dev/github.com/go-faker/faker/v4
MIT License
614 stars 30 forks source link

perf: improve paragragh performance #35

Closed rfyiamcool closed 9 months ago

rfyiamcool commented 9 months ago

summary

improve paragragh performance.

before optimize

goos: darwin
goarch: amd64
pkg: github.com/go-faker/faker/v4
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkParagraph
BenchmarkParagraph-12          21318         50666 ns/op       20836 B/op        164 allocs/op
PASS
ok      github.com/go-faker/faker/v4    1.833s

after optimize

goos: darwin
goarch: amd64
pkg: github.com/go-faker/faker/v4
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkParagraph
BenchmarkParagraph-12          25045         43137 ns/op       17784 B/op         94 allocs/op
PASS
ok      github.com/go-faker/faker/v4    1.867s
codecov-commenter commented 9 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% :tada:

Comparison is base (f70bf73) 89.04% compared to head (f72acc5) 89.16%. Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 89.04% 89.16% +0.11% ========================================== Files 12 12 Lines 1762 1781 +19 ========================================== + Hits 1569 1588 +19 Misses 138 138 Partials 55 55 ``` | [Files Changed](https://app.codecov.io/gh/go-faker/faker/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [lorem.go](https://app.codecov.io/gh/go-faker/faker/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bG9yZW0uZ28=) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/go-faker/faker/pull/35/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.