search

go-faker / faker

Go (Golang) Fake Data Generator for Struct, previously https://github.com/bxcodec/faker
https://pkg.go.dev/github.com/go-faker/faker/v4
MIT License
614 stars 30 forks source link

Deprecate the old module #8

Closed karelbilek closed 1 year ago

karelbilek commented 1 year ago

Please, deprecate the old module, if any new development will happen on this one.

Many people, me included, did not know about this repo (the old repo has 4k stars, this one 40).

karelbilek commented 1 year ago

If you mark the old one as deprecated, go vet and other tools will mark it as such.

bxcodec commented 1 year ago

Okay, I totally missed this

karelbilek commented 1 year ago

The latest commit is good, but I'm not sure if it wouldn't be worth it to also create a tagged release with the deprecation. So it appears when people install with @latest.

bxcodec commented 1 year ago

Oh shoot. I didn't know that. I'll released new version on the old one

karelbilek commented 1 year ago

thx!

karelbilek commented 1 year ago

Seems like you removed it again? :) I don't see the deprecation warning anymore.

you probably had a reason to do that, I guess

bxcodec commented 1 year ago

@karelbilek
Nope, I didn't remove it. Weird... Is the warning still not exist yet?