search

go-fed / activity

ActivityStreams & ActivityPub in golang, oh my!
BSD 3-Clause "New" or "Revised" License
711 stars 111 forks source link

Enable HTTP in a development enviroment #116

Open zauberstuhl opened 5 years ago

zauberstuhl commented 5 years ago

Please Describe The Problem To Be Solved

Following line breaks my local dev setup cause I am obviously not using SSL: https://github.com/go-fed/activity/blob/master/pub/util.go#L1005

(Optional): Suggest A Solution

Introduce a development flag in util.go to switch behavior.

cjslep commented 5 years ago

Thanks for identifying this issue. I'll take a look at fixing this soon.

zauberstuhl commented 5 years ago

Why do you enforce ssl with the lib? Is this part of the specification? Otherwise I would say its up to the project implementation, no?

cjslep commented 5 years ago

It's not a part of the specification. I strongly feel that HTTPS only should be used for ActivityPub based software in production. I don't have a problem with HTTP or self-signed certs plus HTTPS being used for ease of development.

Do you see benefits for using HTTP in production Fediverse software?

zauberstuhl commented 5 years ago

Do you see benefits for using HTTP in production Fediverse software?

no not really