go-fed / activity

ActivityStreams & ActivityPub in golang, oh my!
BSD 3-Clause "New" or "Revised" License
710 stars 111 forks source link

Replace 'inbox' with 'outbox' when appropriate #132

Closed Sigafoos closed 4 years ago

Sigafoos commented 4 years ago

As I was wholesale copying using the database interface definition as a reference while creating my Federating implementation I noticed some instances of a variable being named inboxIRI in an outbox method.

kissen commented 4 years ago

I believe there is a little copy/paste error in a comment as well.

diff --git a/pub/database.go b/pub/database.go
index 10b8484..f42b879 100644
--- a/pub/database.go
+++ b/pub/database.go
@@ -49,7 +49,7 @@ type Database interface {
    //
    // The library makes this call only after acquiring a lock first.
    ActorForOutbox(c context.Context, outboxIRI *url.URL) (actorIRI *url.URL, err error)
-   // ActorForInbox fetches the actor's IRI for the given outbox IRI.
+   // ActorForInbox fetches the actor's IRI for the given inbox IRI.
    //
    // The library makes this call only after acquiring a lock first.
    ActorForInbox(c context.Context, inboxIRI *url.URL) (actorIRI *url.URL, err error)
2.20.1
cjslep commented 4 years ago

Thanks for this! Sorry for the delay.