search

go-fed / activity

ActivityStreams & ActivityPub in golang, oh my!
BSD 3-Clause "New" or "Revised" License
702 stars 111 forks source link

NewId => NewID #133

Closed sevki closed 4 years ago

sevki commented 4 years ago

Id is causing the linters to complain when implementing the db interface. from the go project https://github.com/golang/go/wiki/CodeReviewComments#initialisms

This rule also applies to "ID" when it is short for "identifier" (which is pretty much all cases when it's not the "id" as in "ego", "superego"), so write "appID" instead of "appId".

cjslep commented 4 years ago

Thanks. Once I get the tags in order, I will add this in the next major version release.

cjslep commented 4 years ago

Hey @sevki! I'd like to include this in the v1.0.0 tag release. Mind resolving conflicts and re-submitting for review?

sevki commented 4 years ago

done.

cjslep commented 4 years ago

Thanks a ton!