search

go-fed / activity

ActivityStreams & ActivityPub in golang, oh my!
BSD 3-Clause "New" or "Revised" License
711 stars 111 forks source link

Update go.modverify to go.sum. #77

Closed BenLubar closed 5 years ago

BenLubar commented 5 years ago

Done with two commits to show what's going on more clearly.

cjslep commented 5 years ago

Thanks for the PR! And thank you for splitting this into multiple commits!

I haven't yet caught up on the details Go's latest modularization proposal. Quick question: I noticed that the new lines have a /go.sum suffix appended to the version. Does this mean that the lines without the /go.sum suffix are no longer needed, are only needed for (the older) vgo backwards compatibility, or that the go tool requires both?

FWIW, I am not worried about vgo backwards compatibility, and just want to support what the go tool does. So if the existing lines can safely be deleted, I'm OK with that. Up to you.

If you don't feel like answering my question nor deleting the existing lines, just ACK this comment and I'll merge the PR.

BenLubar commented 5 years ago

In versions of Go that have vgo merged in as go mod, running basically any go command will delete the go.modverify file and create a go.sum file with that content.

It'll even do that if neither go.modverify nor go.sum are present, and it'll give you the same resulting go.sum file (assuming there's not some MITM attack on your build machine).

cjslep commented 5 years ago

Thanks for explaining!