search

go-fed / activity

ActivityStreams & ActivityPub in golang, oh my!
BSD 3-Clause "New" or "Revised" License
711 stars 111 forks source link

Migrate "streams_old" tests to new generated code. #88

Closed cjslep closed 5 years ago

cjslep commented 5 years ago

All streams_old tests have been migrated, only 1 is failing currently, after these commits: ff885a86b398c1959e0f171302517bb5ac0ab4ec ff02890ddf1da20483cf5401fad31bc903948c2c 9e1159dfd2da3e5fd00beea4ce6dc1ecc42e1943 e0e809134f02ad8bde48be712bdfbe370aea9308 0f6ba298b31d413e865bb59b892a0df712a2a145

cjslep commented 5 years ago

Now the main test has all the examples passing:

7beafb477f87c1d8b2629dab20e12bdedf3f5358

However, there is still a null test that needs to be migrated from streams_old

cjslep commented 5 years ago

More major bugfixes:

f90d161ed1128f7a331d4e249384c4ba44b49932 9f792502930d35dc3ac2e09a3d77f7ffa4128049 bc058086d28f506d661937a3b7d7f6f49501e82f 32beb6881edd1726f9be5f8ecb17b87f6d1e166b

All tests from streams_old pass in the new code! Major milestone.

However, I did a small shortcut to get the type property convenience in, which still needs to be fixed before I fully close out this bug and work on migrating the activity/vocab tests. That work is outlined in the commit message:

https://github.com/go-fed/activity/commit/bc058086d28f506d661937a3b7d7f6f49501e82f

cjslep commented 5 years ago

Following commits inject the type property constructor at init time:

a69135b238a86176e678caa158c967f6bad3eed5 9fc75b87b89a05a044f977add0038c59425d33f3