search

go-flutter-desktop / go-flutter

Flutter on Windows, MacOS and Linux - based on Flutter Embedding, Go and GLFW.
https://hover.build/
BSD 3-Clause "New" or "Revised" License
5.85k stars 283 forks source link

Hover: Is it possible to add docker build dependencies without forking Hover? #524

Closed JanezStupar closed 3 years ago

JanezStupar commented 3 years ago

The project I am working for requires additional build dependencies for a plugin. What I have gathered so far, to install say GTK-2 into docker image I would have to fork the Hover project to edit the dockerfile to add the required dependency.

Describe the feature you'd like

Having an ability to specify a local dockerfile or some other way to configure build dependencies.

provokateurin commented 3 years ago

Currently there is no other way than downloading the hover source, changing the Dockerfile and then building the docker image. In previous versions the Dockerfile was added to your project so you could edit it, but that brought some problems.

provokateurin commented 3 years ago

How are you using hover? If you use it in a CI/CD you can use the hover docker image as base and install everything on there

JanezStupar commented 3 years ago

@jld3103 I am currently using it manually via my development machine, but I am going to be using it as a part of my CI setup once I get that far.

provokateurin commented 3 years ago

Can this be closed? There is nothing to do about it other than what I already said

provokateurin commented 3 years ago

I'll just close this, because there was no answer in over a month, but please reopen if needed.

JanezStupar commented 3 years ago

@jld3103 yes the issue can be closed. I got the information I needed and I have no further requests or suggestions. Sorry for not responding sooner.