search

go-flutter-desktop / go-flutter

Flutter on Windows, MacOS and Linux - based on Flutter Embedding, Go and GLFW.
https://hover.build/
BSD 3-Clause "New" or "Revised" License
5.87k stars 283 forks source link

Build Windows #568

Closed Bestfastfire closed 3 years ago

Bestfastfire commented 3 years ago

When I try run hover build windows I awalys get this:

hover: Downloading engine for platform windows-release at version 2c527d6c7e70e2f51bca1a46f1174b250f84c5da...
hover: Failed to download engine: failed to get Content-Length header: strconv.Atoi: parsing "": invalid syntax
hover: Engine builds are a bit delayed after they are published in flutter.
hover: You can either try again later or switch the flutter channel to beta, because these engines are more likely to be already built.
hover: To dig into the already built engines look at https://github.com/flutter-rs/engine-builds/releases and https://github.com/flutter-rs/engine-builds/actions
provokateurin commented 3 years ago

The problem is the CI stopped, because there was no activity on the repo. I already pinged them, but the didn't answer. Maybe we should fork the repo so we can fix it @pchampio @GeertJohan ?

Bestfastfire commented 3 years ago

The problem is the CI stopped, because there was no activity on the repo. I already pinged them, but the didn't answer. Maybe we should fork the repo so we can fix it @pchampio @GeertJohan ?

I forked, do you have any idea how I can make him try to download from my rep instead of the original?

provokateurin commented 3 years ago

You need to change this line: https://github.com/go-flutter-desktop/hover/blob/master/internal/enginecache/cache.go#L312 You also need the actions to be running. I think you need to setup a secret for the actions and the force push so the actions start running. When they succed it should work.

Bestfastfire commented 3 years ago

You need to change this line: https://github.com/go-flutter-desktop/hover/blob/master/internal/enginecache/cache.go#L312 You also need the actions to be running. I think you need to setup a secret for the actions and the force push so the actions start running. When they succed it should work.

I go try, if works, I type here. Dude, ty, you are saving my job kkkkk

Bestfastfire commented 3 years ago

You need to change this line: https://github.com/go-flutter-desktop/hover/blob/master/internal/enginecache/cache.go#L312 You also need the actions to be running. I think you need to setup a secret for the actions and the force push so the actions start running. When they succed it should work.

Do you think it would not be easier to download the file from there manually and make the code do what it has to do with the local zip?

provokateurin commented 3 years ago

I don't understand

Bestfastfire commented 3 years ago

I don't understand

In the code it downloads the rep zip file and then uses it, it wouldn't be easier to download it manually and make the code instead of trying to download it, do what you have to do with it locally

provokateurin commented 3 years ago

Yeah you can download it manually, but why would you do that? The engine builds need to run anyway and changing the repo url is much easier.

Bestfastfire commented 3 years ago

Yeah you can download it manually, but why would you do that? The engine builds need to run anyway and changing the repo url is much easier.

I tried it now but dont works, I think I do something wrong, I changed the code but when I run the command, show same mensage:

Screenshot_237

Screenshot_236

provokateurin commented 3 years ago

Are you on windows? I see there is this release: https://github.com/Bestfastfire/engine-builds/releases/tag/draft, but the actions need to set the proper tag for it

provokateurin commented 3 years ago

I think you tried uploading an old release and use that for hover? It may work, but also may result in problems.

Bestfastfire commented 3 years ago

I think you tried uploading an old release and use that for hover? It may work, but also may result in problems.

Ye, I did it, I have no idea how to proceed, I am totally a layman in go language :/

Bestfastfire commented 3 years ago

I think you tried uploading an old release and use that for hover? It may work, but also may result in problems.

Well, I'm going to finish my project and give the client the debug version for now, it's working fine. If this problem ever resolves or I figure out how to do it, I create the release.

Bestfastfire commented 3 years ago

Forget it, I found a file picker plugin that works without the need for hover, https://pub.dev/packages/file_picker_cross, works well in the standard flutter release.

pchampio commented 3 years ago

@jld3103 yea we can fork the engine build repo. I guess we have no choice choice. Too bad, it’s something else we have to maintain.

provokateurin commented 3 years ago

Actions are now running again, but still we might want to fork the repo to get more control over it.

leedstyh commented 3 years ago

Hi, is this issue has a quick fix?

ChargerMc commented 3 years ago

Any other method to build windows release?

pchampio commented 3 years ago

Actions are now running again, but still we might want to fork the repo to get more control over it.

@all check that your flutter engine version was compiled by rs-flutter. If it was missed due to the action been stoped, please try update your flutter branch. Or use the hover engine-version flag and pick a version available as a rs-flutter/engine-build release.

provokateurin commented 3 years ago

Master channel builds are now succeeding again. Hopefully the other channels will work soon.

ChargerMc commented 3 years ago

Actions are now running again, but still we might want to fork the repo to get more control over it.

@ALL check that your flutter engine version was compiled by rs-flutter. If it was missed due to the action been stoped, please try update your flutter branch. Or use the hover engine-version flag and pick a version available as a rs-flutter/engine-build release.

how? can u explain please?

EDIT: Forget that, I just changed engine version on hover.yaml to engine-version: "b3a18f5182827ca6db20f3e75bfe11b39368b4ec". And worked again.

provokateurin commented 3 years ago

Beta builds are also working again.

leedstyh commented 3 years ago

Hi, I'm still facing this issue, and flutter version is 2.5, hover version is 0.46.6.

niuhuan commented 3 years ago

Hi, I'm still facing this issue, and flutter version is 2.5, hover version is 0.46.6.

I also have this problem. I seem to have found a temporary way.

Run hover with flutter 2.2.3

leedstyh commented 3 years ago

@niuhuan Yeah flutter 2.2 works, it's not a good idea to stay with a lower version of flutter through.

niuhuan commented 3 years ago

@niuhuan Yeah flutter 2.2 works, it's not a good idea to stay with a lower version of flutter through.

I think this problem because "https://github.com/flutter-rs/engine-builds/releases" don't have this commit release.

I tried to specify the engine version before "hover run", it build success , but windows can‘t init. It does not correspond to the commit of flutter.

“hover run” is not have problem because the engine download URL is different

niuhuan commented 3 years ago

hover run: https://storage.googleapis.com/flutter_infra_release/flutter/d3ea636dc5d16b56819f3266241e1f708979c233/darwin-x64/FlutterEmbedder.framework.zip

hover build: https://github.com/flutter-rs/engine-builds/releases/download/f-d3ea636dc5d16b56819f3266241e1f708979c233/macosx_x64-host_release.zip

xiaoxiezaijia commented 3 years ago

hover build: https://github.com/flutter-rs/engine-builds/releases/download/f-bbba2b2437d739a455ecafb66a22a46d31b233ed/windows_x64-host_release.zip is Not Found

niuhuan commented 3 years ago

flutter-rs/engine 's action has stop auto build long time ago, watch forked repertoires build.

Try clone and modify hover sources, change the engine download url , then build hover.

niuhuan commented 3 years ago

flutter-rs/engine 's action has stop auto build long time ago, watch forked repertoires build.

Try clone and modify hover sources, change the engine download url , then build hover.

I had.success download 2.5 engine, but failed to build ( aot error)