search

go-flutter-desktop / go-flutter

Flutter on Windows, MacOS and Linux - based on Flutter Embedding, Go and GLFW.
https://hover.build/
BSD 3-Clause "New" or "Revised" License
5.85k stars 283 forks source link

Hover fails durring Windows build with the --docker flag due to missing tag #616

Closed caesaneer closed 2 years ago

caesaneer commented 3 years ago

Installed the latest. Everything built nicely for Ubuntu. Tried to do a Windows build with the --docker flag.

The build process is failing as follows:

goflutter/hover:v0.46.6 hover-safe.sh build windows --skip-engine-download --version-number 1.0.0+1 docker container: Unable to find image 'goflutter/hover:v0.46.6' locally docker container: docker: Error response from daemon: manifest for goflutter/hover:v0.46.6 not found: manifest unknown: manifest unknown. docker container: See 'docker run --help'.

There are no tags for 46.6, only 46.5 and latest. Not sure if this can be changed to use latest?

provokateurin commented 3 years ago

For some reason the tag hasn't been built. I also can't see the build on docker hub.

provokateurin commented 3 years ago

Ohh so docker hub disabled automatic builds for the tier we currently have. @GeertJohan @pchampio we should create a github action to build and push the image.

zeshuaro commented 2 years ago

Any updates on this? I have the same issue and had to rollback to a previous version of hover in order to run this.

pchampio commented 2 years ago

@jld3103 I'm sorry, I don't have time to work on this at the moment. If @jld3103 doesn't have the time either, @zeshuaro you can still locally compile hover with:

git clone https://github.com/go-flutter-desktop/hover
cd hover
./install-with-docker-image.sh
provokateurin commented 2 years ago

I don't really have time either. The local compile should just work, but people are free to contribute a github action to solve this problem!

ShiinaOrez commented 2 years ago

v0.47.0 also missed on docker hub. And install install-with-docker-image.sh use apt-get, it dose not works on macOS. So who can build v0.47.0 image to docker hub? T o T

ShiinaOrez commented 2 years ago

Solved.

  1. v0.47.0 not exist, but latest exist.
  2. my local hover version is 0.47.0, so I clone newest source code and go build, then copy hover to my go-flutter project dir and run ./hover build xxx --docker, it will use latest image but not v0.47.0, done.
provokateurin commented 2 years ago

install-with-docker-image.sh is just a script for building a docker image. if you got a working docker, then it will just build.