search

go-gandi / terraform-provider-gandi

Terraform provider for the Gandi Domain services
Mozilla Public License 2.0
152 stars 45 forks source link

mutable flag for txt livedns_records #111

Closed adriamanu closed 2 years ago

adriamanu commented 2 years ago

The purpose of this PR is to add a mutable flag on livedns_records to be able to manipulate records that are susceptible of being already existant / modified aside Terraform. With this pull request, gandi provider will only touch records managed by Terraform by doing PUT crud operation from gandi api in order to update/edit the list of records. This is the related issue

adriamanu commented 2 years ago

Hello @nlewo , i hope you are doing well. i updated pr according to your requested changes (some logic modification / unit tests / generate documentation). Apologies for the delayed update. Took me some time to test it again and check for edge cases. Have a good day !

nlewo commented 2 years ago

I did some manual tests and wrote an acceptance test in #117.

Everything looks fine :tada:

@adriamanu Once this PR is merged, i will rebase #117.

adriamanu commented 2 years ago

I'm glad to read that ! @nlewo rebase has been done so that there is only 1 commit to merge (typos have been fixed during the rebasing process).

nlewo commented 2 years ago

@adriamanu Thank you!

adriamanu commented 2 years ago

Thank you for the support, keep up the good work @nlewo 🙏🏼 !