search

go-gandi / terraform-provider-gandi

Terraform provider for the Gandi Domain services
Mozilla Public License 2.0
152 stars 46 forks source link

Add resource to manage DNSSEC keys #56

Closed insertjokehere closed 2 years ago

insertjokehere commented 3 years ago

This adds a gandi_dnssec_key resource to manage DNSSEC keys for domains managed through Gandi

Depends on https://github.com/go-gandi/go-gandi/pull/20

Fixes #54

robbyoconnor commented 2 years ago

This should be good to go.

tiramiseb commented 2 years ago

@robbyoconnor it needs updating the dependency :-) (go get -u blah blah, go mod tidy so that go.mod and go.sum are up-to-date)

robbyoconnor commented 2 years ago

https://github.com/go-gandi/terraform-provider-gandi/pull/60

robbyoconnor commented 2 years ago

@tiramiseb wrong PR merged!

robbyoconnor commented 2 years ago

60 had the changes from here.

robbyoconnor commented 2 years ago

@insertjokehere I appreciate your work here, thank you for doing this. I apologize if my reviewing them and getting them merged upset you in any way.

insertjokehere commented 2 years ago

@insertjokehere I appreciate your work here, thank you for doing this. I apologize if my reviewing them and getting them merged upset you in any way.

not at all - this is my first time writing Go, so I'm just happy that it could be a useful starting point. Glad to see this project is getting some maintenance, hopefully we'll see a release on the registry some time soon!

robbyoconnor commented 2 years ago

Not a maintainer, just a guy who had a stake in it and wanted it. I feel like coming in and working off of it was a bad move -- I mean I didn't hide it; I just wanted to bring it in-line with best practices :)

Also, I'm kind of new-ish to Go myself. Named returns are a freaking weird concept.

tiramiseb commented 2 years ago

Well, a maintainer is "just a guy" too :wink:

As the original developer blah blah blah (and I am "just a guy" too, hehe), I am glad you have taken over this. You had the intelligence to keep others' authorship and that is good. Apart from saying "thank you", which I don't do often enough, I'm okay with all this.

I hope your next PRs will add great features and I'm looking forward to receiving them :smile:

robbyoconnor commented 2 years ago

@tiramiseb true, true and I do feel bad for doing this. Didn't realize anyone would have an issue with it. I also fall on the autism spectrum with ADHD to boot =)

I have a migration to complete and wanted to have everything done from terraform. I hate point and click