Closed theAkito closed 4 years ago
Have you tried forcing a cache reload? Or un-registering the serviceworker and letting it re-install?
@jolheiser No, did not try that, yet. How would I go about doing that?
Meanwhile, I got the old binary back and use this one in the new installation and all is back to normal, as long as this issue ain't fixed, yet.
Was this built from source? Does public/js/clipboard.js
exist in your source checkout?
@silverwind
Yes. I have an update.sh
that I use to update Gitea successfully since more than a year. It fetches the newest sources, gets dependencies, etc. then it builds everything from source.
Does
public/js/clipboard.js
exist in your source checkout?
Yes.
Try starting up once with ui.USE_SERVICE_WORKER = false
, open the page and then with true
again, this should unregister/re-register the service worker.
There is a underlying bug somewhere, but I wonder if SW re-registration helps any or if the error is persistent.
@silverwind
Well, turns out, that I changed my update.sh
script and forgot to add a go get ...
line. I updated most of the dependencies and stuff works now. Thanks everyone.
That said, I encounter 2 other errors when trying to fetch dependencies using go get...
:
I wasn't able to fix No2, because I don't know which mod/depedency depends on influxdb as a mod/depedency. Therefore I can't fiddle with the go.mod
, etc. I just know the most basic stuff about Go, so maybe someone of the more experienced people here could easily solve this.
Weird that go dependencies would cause JS errors, I don't believe it. Maybe your build was just unclean. Regarding go modules, I don't think you actually need to go get
as we vendor them all inside the repo currently.
@silverwind
So the go get ...
is redundant?
Maybe your build was just unclean.
Certainly cannot guarantee it wasn't, however it never caused any remarkable issue, like this one. That said, if it was unclean, it's probably still unclean, as I didn't change the folder or anything like that. All I did was:
influxdb
issueSo, at least it appears to be connected to dependencies, though I wouldn't know how to confirm it.
Regarding cleaning: Running make clean-all
should get you absolutely clean minus node_modules
which you can optionally delete too, so rm -rf node_modules && TAGS=bindata make clean-all build
should suffice.
I'm no expert on go build, but I've been building without any go get
a long time now.
@silverwind
I've been building without any
go get
a long time now.
Same here. I just didn't know about the vendoring possibility.
Regarding cleaning: Running
make clean-all
should get you absolutely clean minusnode_modules
which you can optionally delete too, sorm -rf node_modules && TAGS=bindata make clean-all build
should suffice.
Should this be run before every new build?
Ideally, our make
process should figure out what needs rebuilding but to avoid any potential bugs in that complex process, it never hurts to clean-all
. Build will of course take a minute or two longer.
Please close if resolved.
Big thank you to everyone involved in helping!
[x]
):Description
Web Console
Screenshots