go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.45k stars 5.52k forks source link

heatmap: untranslated string: xx total contributions in the last 12 months #10669

Closed dadosch closed 1 year ago

dadosch commented 4 years ago

Description

The string in the heatmap is not translated:

xx total contributions in the last 12 months

https://github.com/go-gitea/gitea/blob/062f35109df236a06a00d403d006b90760f9cfac/web_src/js/features/userHeatmap.js#L82

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

a1012112796 commented 4 years ago

ping ...

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

dadosch commented 4 years ago

it is still a issue

Ryuno-Ki commented 2 years ago

The code was refactored into

https://github.com/go-gitea/gitea/blob/d9b50e4fd126e60fe0735bafbcb12d0e8f6dd0c2/web_src/js/components/ActivityHeatmap.vue#L3-L5

Ryuno-Ki commented 2 years ago

Given https://github.com/julienr114/vue-calendar-heatmap/issues/19 it might be worth looking for alternatives (once Vue 3 migration is to start).

https://github.com/go-gitea/gitea/blob/d9b50e4fd126e60fe0735bafbcb12d0e8f6dd0c2/web_src/js/components/ActivityHeatmap.vue#L8-L9

reference

https://github.com/go-gitea/gitea/blob/d9b50e4fd126e60fe0735bafbcb12d0e8f6dd0c2/web_src/js/components/ActivityHeatmap.vue#L39-L42

and wouldn't be translated either.

A fork exists as TypeScript project at https://www.npmjs.com/package/vue3-calendar-heatmap

lunny commented 2 years ago

Given julienr114/vue-calendar-heatmap#19 it might be worth looking for alternatives (once Vue 3 migration is to start).

https://github.com/go-gitea/gitea/blob/d9b50e4fd126e60fe0735bafbcb12d0e8f6dd0c2/web_src/js/components/ActivityHeatmap.vue#L8-L9

reference

https://github.com/go-gitea/gitea/blob/d9b50e4fd126e60fe0735bafbcb12d0e8f6dd0c2/web_src/js/components/ActivityHeatmap.vue#L39-L42

and wouldn't be translated either.

A fork exists as TypeScript project at https://www.npmjs.com/package/vue3-calendar-heatmap

We still stayed in Vue2 currently.

wxiaoguang commented 2 years ago

I have a feeling that there might not be too many blockers for upgrading to Vue3. And since the usage of Vue2 in Gitea is still at an early stage, if enough people agree, we should try to upgrade to Vue3.

Ryuno-Ki commented 2 years ago

I'm migrating another project to Vue 3 currently. My learnings from there:

Can we reference this issue in a new issue about Vue 3? There are different places (like documentation etc) that would need updates, so some kind of meta-issue could help to keep track of them.