search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.18k stars 5.42k forks source link

Proxysupport for webhooks #1094

Closed Schwobaland closed 7 years ago

Schwobaland commented 7 years ago

It should be possible to set a http-proxy in app.ini for webhooks. There should be 3 properties:

Alternatively env-variables could be used. This would ease the docker-deployment.

tboerger commented 7 years ago

That should already work if your system provides these environment variables?

Schwobaland commented 7 years ago

I tested on MacOS and Windows - and it doesn't work. I think, because of the proxy-property is always overwritten here. In default go-Transport-implementation ProxyFromEnvironment is used.

lunny commented 7 years ago

resolved by #1096