go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.78k stars 5.47k forks source link

access table should store all explicit accesses to repository #11558

Open CirnoT opened 4 years ago

CirnoT commented 4 years ago

Currently it does not store explicit read access, even for private organizations or for restricted users.

This is because of https://github.com/go-gitea/gitea/blob/5789e603161aff311f8afcc15585892e783c931e/models/access.go#L190-L192

The code was introduced with Gogs in https://github.com/go-gitea/gitea/commit/473e265727c1e47dd83e3f66a5cc92d2f027d951

If removed, migration would be required to recalculate accesses for current teams.

mrsdizzie commented 4 years ago

This would be needed for proper issue assignment without having to walk through every team with access

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

CirnoT commented 4 years ago

bad bot

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.