go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.48k stars 5.44k forks source link

"UserSignIn: EOF" when using custom openid connect login source #11928

Closed bendem closed 4 years ago

bendem commented 4 years ago
click for logs ``` server_1 | [Macaron] 2020-06-17 13:14:35: Started GET /user/oauth2/vdl-sso for 10.0.2.2 server_1 | 2020/06/17 13:14:35 ...s/context/context.go:330:func1() [D] Session ID: a6e81ba41a7da892 server_1 | 2020/06/17 13:14:35 ...s/context/context.go:331:func1() [D] CSRF Token: IDOlk4EEJkIwSNM7JKC0AbmsGYI6MTU5MjM4ODEzNzU1MDUyODU4Ng server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:78:queryRows() [I] [SQL] SELECT "id", "type", "name", "is_actived", "is_sync_enabled", "cfg", "created_unix", "updated_unix" FROM "login_source" WHERE (name = $1 and type = $2 and is_actived = $3) LIMIT 1 []interface {}{"vdl-sso", 6, true} - took: 5.286113ms server_1 | [Macaron] 2020-06-17 13:14:35: Completed GET /user/oauth2/vdl-sso 307 Temporary Redirect in 16.990802ms server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:196:exec() [I] [SQL] INSERT INTO "oauth2_session" ("id","data","created_unix","updated_unix","expires_unix") VALUES ($1, $2, $3, $4, $5) []interface {}{"5ICE6U5SP76QEGKQD2F46PWQ7OMM4SHEQDWJDLAV32FY4OX3DH2A", "MTU5MjM5OTY3NXxEdi1CQkFFQ180SUFBUkFCRUFBQV9nRXhfNElBQVFaemRISnBibWNNQ1FBSGRtUnNMWE56YndaemRISnBibWNNX2dFUUFQNEJEQi1MQ0FBQUFBQUFBUDlNakY5THd6QVVSN19MaGJ3dFc1YTZzaFdLRkxRZy1EVG1pd2dsM2x4dFdHaEs3dTN3RDM1M1dhY2lfRjUtaDhQNWhHYVNfbUZfRHhYMElpTlhxNVdicEYtZWZGeUdRYkpicGZPM00wMDVmTkExeGtDRGRNSFhyMEhJNlpqUXhhZkpHRnRtOGlFVFNqZmxVSjk3cW1pVWJaVnRaNmxQTEtwb0NtT01zdTNFbEpWdEwzMWwyNU9QbWprcDI2S0w4ZG5oOFRmS1l4cVlPbmtmcWNiazZjSVowMGgxR21rSV9vZUlFNnJOWmtPNEtkZTZkTTdxcThKNXZhTXQ2bkpYbWkyVk80LTJnQVUwaU1SOFNFY2FvQUpZd0o1ZU1uSF9qOXktalNFVE53SVZHR1BXZXQ3Qm1HcmVJeXpnN3ViUF9fb0dBQURfX3dFQUFQX194bXo0cEUwQkFBQT18wnnUbI5jscxaaaVB51H9e3opE2nYtfmO4IrCpkKCzCk=", 1592399675, 1592399675, 1594991675} - took: 10.726007ms server_1 | [Macaron] 2020-06-17 13:14:35: Started GET /user/oauth2/vdl-sso/callback?code=139982b0a2ed632cdf18f0fa3ec25eb5&state=055ec561-6aa2-43ad-9e8c-69608e69dc23&session_state=z2s0MPBu2mOyiYQW5h99avaZtaA01e7ekXk9D4NBXPs%3D.d2dUejAvZGVKSk1Bd0RDN1hSMWtYZz09 for 10.0.2.2 server_1 | 2020/06/17 13:14:35 ...s/context/context.go:330:func1() [D] Session ID: a6e81ba41a7da892 server_1 | 2020/06/17 13:14:35 ...s/context/context.go:331:func1() [D] CSRF Token: IDOlk4EEJkIwSNM7JKC0AbmsGYI6MTU5MjM4ODEzNzU1MDUyODU4Ng server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:78:queryRows() [I] [SQL] SELECT "id", "type", "name", "is_actived", "is_sync_enabled", "cfg", "created_unix", "updated_unix" FROM "login_source" WHERE (name = $1 and type = $2 and is_actived = $3) LIMIT 1 []interface {}{"vdl-sso", 6, true} - took: 5.131024ms server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:78:queryRows() [I] [SQL] SELECT "id", "data", "created_unix", "updated_unix", "expires_unix" FROM "oauth2_session" WHERE (id = $1 AND expires_unix >= $2) LIMIT 1 []interface {}{"5ICE6U5SP76QEGKQD2F46PWQ7OMM4SHEQDWJDLAV32FY4OX3DH2A", 1592399675} - took: 4.775375ms server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:78:queryRows() [I] [SQL] SELECT "id", "data", "created_unix", "updated_unix", "expires_unix" FROM "oauth2_session" WHERE (id = $1 AND expires_unix >= $2) LIMIT 1 []interface {}{"5ICE6U5SP76QEGKQD2F46PWQ7OMM4SHEQDWJDLAV32FY4OX3DH2A", 1592399675} - took: 3.633292ms server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:196:exec() [I] [SQL] UPDATE "oauth2_session" SET "data" = $1, "updated_unix" = $2, "expires_unix" = $3 WHERE "id"=$4 []interface {}{"MTU5MjM5OTY3NXxEdi1CQkFFQ180SUFBUkFCRUFBQV9nS2NfNElBQVFaemRISnBibWNNQ1FBSGRtUnNMWE56YndaemRISnBibWNNX2dKN0FQNENkeC1MQ0FBQUFBQUFBUDg4a0cxdm96Z1VoZi1MSmI2VkZNeExRNlJveFpKQ29YRTZRd0lFdEZKa2JLZTRJY0JnNTRXczlyLXZTQ2Z6OFI2Zjg5emoteTl3VDdKSzRpV1lnVXJLVHN5ZW5fRkpWcE16clNlOGtUMS1ic2NaM3RXMjV6ZjJGNms1YS1TTzBfa25sd3lyZFV0d19jOUowNkRkTThwN1J1VHUxUFA1eUZNTVY0Ry1BdjI3cVdxRlZBelgwRFJOZ2Y1SnNGNkJfamRmZ2Y2WjFxb1FyUUo5Z3V1NnhPVHdnSXF1YlFUYnlhRmpjOUpTOXEwTDBuWnMzbmFzNGZTM0lyRmtjODJ5R0xGc1hiVXhocXBwWUtvNmJFcFUyN0cxS2JNZFNxQUJub0JMQ0JOaTB4NVlBMlpnYjVhTTB0SWhlOVBDVThaMGt4RmphdXAwN3pqNGhaWGdDY1JzM3pOUlBSTGdDYnhlTzk0ejRVb3dBMUNEbXFyWnF2NnkwYzJaYnM0TWF3SjF5OVJOLS1XbEFFOGdYRHlTYkloNm5QM2tIenlDUlhEaFN5LXF5b0NNYzVqY2tpdmlvUWliMkNKZWFJZUhicHQ2a1ROaFExVGxSamlhUkFsZkpScENFUjVUY3pTaFRXS2hyNThYZEF1TmxYZmhlTHU2aFY4dHgyLXhSdDZRdlJ5Y2ltN2pkdGtVaDlLenVyS0poM3c5NW4yZEJ0V2VCclVzMWc4T01qOFdTRVBlaFJNajVTT25DRktaYnlPdHlIdzlIOHNkNjRyLTJZdXNqMDEtMzV0dnU4dmREMnV0eUY1bEdUaGZlZmI5UWVvN2JiNWR0ZU03Z3RXd1dVUU5OV3BKWDlOM21rUWV5Z3FiWmRlWUhvdDlsazVsZHF5UHE4U3AwY0kxa0VIZlZfVmhTSDUzTHNiREhHbEhnN1JhWnRkekRuMFJOdHBralhZZlFyZ1dibGhfLXZWamRfaDB6cjgybmJIRTZ5czE0YUpLTnJickktYWxxNi0zbXhuX25ZakEwOV9NWWhDNUZheU5Va2JORF9iNUh1cFhXWGs3a255R2g2VUxfdnNmQUFEX193RUFBUF9fSW1jUW1TWURBQUE9fHa3BrCJ7VJMYJ1HdYnHNmMxSiF2DfWW4obL4t0kbeqL", 1592399675, 1594991675, "5ICE6U5SP76QEGKQD2F46PWQ7OMM4SHEQDWJDLAV32FY4OX3DH2A"} - took: 9.670955ms server_1 | 2020/06/17 13:14:35 .../xorm/session_raw.go:196:exec() [I] [SQL] DELETE FROM "oauth2_session" WHERE "id"=$1 []interface {}{"5ICE6U5SP76QEGKQD2F46PWQ7OMM4SHEQDWJDLAV32FY4OX3DH2A"} - took: 5.319293ms server_1 | 2020/06/17 13:14:35 routers/user/auth.go:601:handleOAuth2SignIn() [E] UserSignIn: EOF server_1 | 2020/06/17 13:14:35 ...s/context/context.go:139:HTML() [D] Template: status/500 server_1 | [Macaron] 2020-06-17 13:14:35: Completed GET /user/oauth2/vdl-sso/callback?code=139982b0a2ed632cdf18f0fa3ec25eb5&state=055ec561-6aa2-43ad-9e8c-69608e69dc23&session_state=z2s0MPBu2mOyiYQW5h99avaZtaA01e7ekXk9D4NBXPs%3D.d2dUejAvZGVKSk1Bd0RDN1hSMWtYZz09 500 Internal Server Error in 103.632731ms ```

Description

We setup oauth2 with lemonldap-ng (hit the same problem as #8356), after manually updating the source, we get to the providers's login page, but the redirect back to gitea ends with an error 500 "EOF" (see above). We have no error or misbehavior that I can see from lemonldap-ng and without more information from gitea it's hard to tell where to go.

bendem commented 4 years ago

This was due to a misconfiguration on our hand. The userinfo route did not return anything (thus EOF). The solution: https://gitlab.ow2.org/lemonldap-ng/lemonldap-ng/issues/1593