search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.84k stars 5.38k forks source link

Octicons are missing for dashboard repolist #12226

Closed CirnoT closed 4 years ago

CirnoT commented 4 years ago

Description

https://github.com/go-gitea/gitea/pull/12157 introduced direct SVG rendering however no appropriate changes were made to dashboard repolist https://github.com/go-gitea/gitea/blob/bac57ab5900672357fb0a36f9433e516088bd21b/templates/user/dashboard/repolist.tmpl#L64

silverwind commented 4 years ago

There's more:

https://github.com/go-gitea/gitea/blob/bac57ab5900672357fb0a36f9433e516088bd21b/templates/user/dashboard/repolist.tmpl#L106

A template language inside another template language. I don't think it's such a great idea.

silverwind commented 4 years ago

I really wonder why there is even vue templates mixed in the go templates using pseudo-global JS functions. Those should be standalone .vue files.