go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.39k stars 5.43k forks source link

Issue - heatmap is mini-heatmap #13634

Closed wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf closed 3 years ago

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented 3 years ago

Description

Appears to be introduced by #13623 . The issue is that the heatmap appears really small. I have tried to reproduce it in chromium, firefox and brave (chromium-based) and this issue only pertains in chromium (consistently). For the user dashboard to pop up you have to be logged in, in chromium, though, you can also see the issue when navigating to user's 'Public Activity' page (https://try.gitea.io/kjhfdskahhjksdf?tab=activity), for which you, obviously, don't have to be logged in.

Screenshots

my instance image try.gitea.io logged in (Public Activity) pic1 image try.gitea.io logged in (dashboard) pic2 image try.gitea.io logged out (activity) image

edit: missing parenthesis (image not showing properly) edit2: add blame

6543 commented 3 years ago

@silverwind some sort of chrome css incompatiblety?

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented 3 years ago

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf I dont have this issue :/ it looks like you have to clear your browser cache

I already did...

6543 commented 3 years ago

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf sorry - didnt read the " ... chrome ..." the first time ...

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented 3 years ago

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf sorry - didnt read the " ... chrome ..." the first time ...

no worries. and I only tried chromium. don't use chrome so can't confirm it's present there (since the issue is e.g. not present in chromium-based brave).

silverwind commented 3 years ago

I think I only tested this in Firefox if I recall correctly.

bkraul commented 3 years ago

Any chance #13645 be merged soon? I'd be happy with the current heatmap if I was an ant right now, but since I am not... 🙂

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented 3 years ago

Any chance #13645 be merged soon? I'd be happy with the current heatmap if I was an ant right now, but since I am not...

for now, you could build Gitea with the patch (that's what I've done)...

cd gitea-src-folder
curl -O https://patch-diff.githubusercontent.com/raw/go-gitea/gitea/pull/13645.patch
git am 13645
make build # specify desired TAGS before this...

@bkraul

edit silly typo: git am 12645 --> git am 13645