Panic on organization avatar

[jeanlucmongrain]

Since I upgraded to latest release I get panic when it get avatar, URL is /avatars/$ORG_ID

• Gitea version (or commit ref): 1.13.0
• Operating system: K8s and official helm chart latest version
• Database (use [x]):
  • [x] PostgreSQL
  • [ ] MySQL
  • [ ] MSSQL
  • [ ] SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • [ ] Yes (provide example URL)
  • [x] No
• Log gist:

[Macaron] PANIC: middleware render hasn't been registered
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/render.go:653 (0xd91398)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/render.go:710 (0xd9137d)
/go/src/code.gitea.io/gitea/routers/routes/routes.go:166 (0x21aa215)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:79 (0xd87492)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xd85e14)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xd85bb9)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd8761c)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0xd991a5)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/recovery.go:161 (0xd99198)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:40 (0xd8b1d7)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xd85e14)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xd85bb9)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd8761c)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/router.go:187 (0xd9a3f0)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/router.go:303 (0xd93b85)
/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/macaron.go:218 (0xd8c54d)
/go/src/code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0x1293493)
/usr/local/go/src/net/http/server.go:2042 (0x77b583)
/usr/local/go/src/net/http/server.go:2843 (0x77eb82)
/usr/local/go/src/net/http/server.go:1925 (0x77a38c)
/usr/local/go/src/runtime/asm_amd64.s:1374 (0x477dc0)

[zeripath]

The underlying error is coming from here:

https://github.com/go-gitea/gitea/blob/8e8e8ee150a70e882bf4661fab84382befe29ac0/routers/routes/routes.go#L166

within the storage handler. Now I'm certain I've fixed this on master but it doesn't appear to have been backported on to 1.13

[zeripath]

Yup #13164 wasn't completely backported:

https://github.com/go-gitea/gitea/blob/8e8e8ee150a70e882bf4661fab84382befe29ac0/routers/routes/routes.go#L226-L229

Line 229 needs to come before 226

[melroy89]

oopsy..