[API] GET ​/repos​/{owner}​/{repo}​/contents​/{filepath} returns null content on big files

[danielemoroni]

• Gitea version (or commit ref): 1.12.3 and 1.14.0+dev-587-g61f9a72f2
• Git version:
• Operating system:
• Database (use [x]):
  • [ ] PostgreSQL
  • [ ] MySQL
  • [ ] MSSQL
  • [ ] SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • [x] Yes (https://try.gitea.io/danielemoroni/bigfile_test)
  • [ ] No
• Log gist:

Description

I uploaded a 14MB file to a repository, and tried the API GET ​/repos​/{owner}​/{repo}​/contents​/{filepath}. Example in try.gitea.io swagger: curl -X GET "https://try.gitea.io/api/v1/repos/danielemoroni/bigfile_test/contents/bigfile.dat" -H "accept: application/json"

I get a response 200 but the content is empty. It's fine if I use the raw api instead, GET /repos/{owner}/{repo}/raw/{filepath}.

Is this a known limit in gitea? I couldn't find any documentation or issue about it.

Screenshots

[lunny]

~It's OK from me.~

[danielemoroni]

The response is ok, but content is empty. It's at the end of the first line in your screenshot: "content": ""

For smaller files that field is populated with the file content (as a base64 string).

Incidentally the limit seems to be around 10MB, as I can get a 9.6MB file ok.

[6543]

I think this is because to convert it into json the whole file is first loaed into mem and then encoded ... to solve this It looks like we have to stream encode it ...?