search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.02k stars 5.49k forks source link

web interface - spellchecker of the browser not available #18532

Closed flobee closed 2 years ago

flobee commented 2 years ago

Feature Description

The default behavior for spell checking of the browser does not work in forms. e.g when editing a README.md and want to use spell checks

Screenshots

not possible within a right mouse click

silverwind commented 2 years ago

There is spellcheck="false" set on the underlying texarea which was probably to work around some issue. We can remove it but I'm not sure whether spell checking can even work with CodeMirror, those might require a standard <textarea>.

flobee commented 2 years ago

Well. Never refactor/reset standard browser functionality. Removing default user control is a completetly NOGO since ages >25Y i experience. Make all default browser standards available/possible as good you can.

wxiaoguang commented 2 years ago

There is an option for EasyMDE/CodeMirror.

spellChecker: If set to false, disable the spell checker. Defaults to true. Optionally pass a CodeMirrorSpellChecker-compliant function.

However it was set to false in history in Gitea code. I do not think it's correct (well, maybe it was somehow correct at that moment, but there is no comment at all). The code was just Copied&Pasted from https://github.com/go-gitea/gitea/commit/2b10fdc4 .

A simple PR can fix this problem (maybe not simple)

wxiaoguang commented 2 years ago

Please test #19776