go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.82k stars 5.38k forks source link

Users added to "Teams" are automatically added to watchers on all repos in organization #23892

Open sgabenov opened 1 year ago

sgabenov commented 1 year ago

Description

When you add new user to Team, this user is automatically subscribed to watch on all repos in the organization. The planed behavior is to add user WITHOUT watching all repos.

Also, it would be great, if there was a function to manage subscriptions by Admin for managed users, so you can in batch operation subscribe or unsubsribe users to watch repos.

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

PostgreSQL

silverwind commented 1 year ago

Do we know how this works on other Forges like GitHub or GitLab? I'm kind of torn on this one as sometimes these auto-watches are useful, but I do recall complaints about them too.

BElluu commented 1 year ago

I'm pretty sure that's not how it works on github. However, for some it may be a feature and for others a bug, so I would parameterize it in the organization's settings.

silverwind commented 1 year ago

Yes, per-org configuration would be ideal, and a default in app.ini that applies to new orgs.

melmus commented 1 year ago

I agree with author this issue. Can you add some option in app.ini to fix problem?

gabriel-vasile commented 1 year ago

There is a app.ini setting for this but it seems to have 2 purposes:

  1. tell if new repo should be automatically watched by members
  2. tell if new member should automatically watch all repos

https://github.com/go-gitea/gitea/blob/92e07f270aa925d518b13686f78befb63da0a747/custom/conf/app.example.ini#L874-L877 https://github.com/go-gitea/gitea/blob/92e07f270aa925d518b13686f78befb63da0a747/models/org_team.go#L504-L518

silverwind commented 1 year ago

app.ini setting is fine for global default, but per-org override config in UI would be nice.

ddi-acassidy commented 1 year ago

per-user would be nice as well. Not all users need or want notifications for everything in the organization

AndersBennedsgaard commented 4 months ago

I fully agree with @ddi-acassidy . It would be nice with something similar to the notifications tab in Github: https://github.com/settings/notifications

lunny commented 3 months ago

So I think this issue proposal a per-user level notification setting UI but not a bug.

AndersBennedsgaard commented 3 months ago

I forgot to mention that I created https://github.com/go-gitea/gitea/issues/30537, which is a proposal for per-user notification settings.

I don't think this is a duplicate, due @sgabenov's proposal for

[...] a function to manage subscriptions by Admin for managed users, so you can in batch operation subscribe or unsubsribe users to watch repos.

unless we think that https://github.com/go-gitea/gitea/issues/30537 solves that

zc-devs commented 2 months ago

It goes funny when you set users as private/hidden:

Screenshot 2024-06-23 134742 Screenshot 2024-06-23 134852

Create test repository and look from guest: Screenshot 2024-06-23 140204 Screenshot 2024-06-23 135028

Gitea 1.22.0, 1.21.11