go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.81k stars 5.47k forks source link

Feishu webhook of issue update not linking to full issue url #24368

Closed xgdgsc closed 1 year ago

xgdgsc commented 1 year ago

Feature Description

I hope webhook of issue update include issue url. I find it strange commit webhook has URL while issue webhook notifications has no URL, which I usually would use more frequently,

Screenshots

No response

Makonike commented 1 year ago

hi, @xgdgsc . Can you please reproduce and provide a detailed description of the issue? I'm not quite clear on what "issue webhook notifications has no URL" means. It's possible that this issue has already been resolved in the latest version.

image
xgdgsc commented 1 year ago

I see only

{
  "msg_type": "text",
  "content": {
    "text": "#2 tst1\r\n[org/repo1] Issue closed: #2 tst1 by user1"
  }
}

when using Feishu webhook.

techknowlogick commented 1 year ago

@xgdgsc which version of gitea are you using?

xgdgsc commented 1 year ago

Just downloaded latest release 1.19.3

Makonike commented 1 year ago

I will fix this later.

Makonike commented 1 year ago

hi @xgdgsc, I have submitted a Pull Request to fix this issue. Since the official documentation states that custom webhook bots do not support hyperlink functionality, simply adding it without making some formatting changes would result in an unappealing output. Therefore, I have modified the formatting of the output. You can also try using a custom bot application. I have previously written one that you can refer to. The repository is located here: webhook2group

xgdgsc commented 1 year ago

The commit notification message already has the url, which is fine and clickable. So I think just adding the url to the text would be fine? I' ve never used any custom bot before, just used the webhook bot.

Makonike commented 1 year ago

The commit notification message already has the url, which is fine and clickable. So I think just adding the url to the text would be fine? I' ve never used any custom bot before, just used the webhook bot.

Yeah, my PullRequest will fix this.