search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.02k stars 5.49k forks source link

EasyMDE toolbar is broken #24486

Closed wxiaoguang closed 1 year ago

wxiaoguang commented 1 year ago

Related to https://github.com/go-gitea/gitea/pull/24471

I think we should keep EasyMDE, or at least find an alternative. Because when writing Wiki page, it is useful.

image

silverwind commented 1 year ago

I thought https://github.com/go-gitea/gitea/pull/24448 had replaced all these toolbar icons, but apparently only some. I guess we should restore with octicons.

yardenshoham commented 1 year ago

24448 removed direct references, not indirect ones. This probably broke after https://github.com/go-gitea/gitea/pull/24471

yardenshoham commented 1 year ago

Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

wxiaoguang commented 1 year ago

We can manually construct every toolbar button, to use other icon sets.

silverwind commented 1 year ago

Yes, my oversight there. If the restoration is too much work, we could drop EasyMDE as well.

Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

No, it apparently has an option autoDownloadFontAwesome which downloads it from CDN, but of course we needed to disable that as we don't want such downloads to happen.