search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.21k stars 5.32k forks source link

ACME default storage not using work-path setting #26590

Open EniacMlezi opened 11 months ago

EniacMlezi commented 11 months ago

Description

Looks like the ACME 'https' directory is just created in the curren directory, not accounting for the work-path settings.

https://github.com/go-gitea/gitea/blob/e5b3f53d36b69ce73cf2870cddd13cd15a799424/cmd/web_acme.go#L58

Gitea Version

1.20.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

In an azure VM packeged by Bitnami

Database

None

lunny commented 10 months ago

If setting.AcmeLiveDirectory is a relative path, the parent path should be DataPath

yp05327 commented 3 months ago

If setting.AcmeLiveDirectory is a relative path, the parent path should be DataPath

It seems that we didn't do that. image image