search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.19k stars 5.42k forks source link

Allow adding reviewers for issues #29068

Open rijenkii opened 7 months ago

rijenkii commented 7 months ago

Feature Description

Commonly in my usage of Gitea I find myself wishing that Gitea had an ability to differentiate regular "assignees" from "reviewers" of the issue. Commonly reviewer is the person that created the issue, but not always.

This will also simplify filtering of the issues, allowing to differentiate between issues that you have to implement vs issues that you have to review.

Screenshots

image

delvh commented 7 months ago

Hmm… Yes, but that brings other architectural questions I'm not sure I want to answer. Currently, a PR is only coupled to an issue insofar as a PR might state something like Closes #issue to notify the issue to close on merge.

However, your intended feature only works well when there is a stricter coupling of issue and PR, as in you are forced to specify which issue(s?) a PR fixes as soon as you create it (and perhaps afterwards). I'm not sure if that's the correct direction to go, as it is a complete rewrite of the current PR process with a different architecture for a small benefit (there is a measurable benefit, but is it worth all this effort?).

Why would we even need all these changes? Well, if we don't, then your feature only works when users are nice enough to not have forgotten which issues will be fixed by a given PR, or in other words it can be practically useless if they forget to note that. That's neither a good idea nor user-friendly. Plus, selecting the issues that concern your PR is a UI design I'm not entirely sure I want to dive deeper into, as it sounds like an endless rabbit hole on first thought.

rijenkii commented 7 months ago

My proposal does not mention anything about PRs. I know that it is possible to assign reviewers to PRs, I am asking specifically to independently assign reviewers to issues, so that they could check the implementation on the dev server after the PR(s) linked to the issue were merged, as there may be multiple PRs to completely fix/implement the issue.

Basically I want a duplicate of "Assignees" without any additional features, for ease of filtering.

Of course it would still be possible to close an issue by merging a PR, but in my use case we never do that, as a feature may require multiple PRs, or no PRs at all (commits are just pushed into the trunk, referencing issue in the title or body).