search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.04k stars 5.32k forks source link

contributors graph respect "Co-authored-by" #29183

Open 6543 opened 4 months ago

6543 commented 4 months ago

the initial implementation ( #27882) does not use the Co-authored-by: information in commit messages.

but especially in repos like e.g. this one, where squash merge is used, you loose a lot of information.

https://github.com/go-gitea/gitea/blob/21331be30cb8f6c2d8b9dd99f1061623900632b9/services/repository/contributors_graph.go#L119

has to be extended ...

sahinakkaya commented 4 months ago

I actually didn't quite understand what you mean by that line of code has to be extended but I agree a lot of information is lost on squash. I always split my work into meaningful commits so that I could easily revert one of them if it is not needed or introduces a bug. It is not that easy to revert when they are squashed.

6543 commented 4 months ago

@sahinakkaya that's not a critic of your work :)

it's a follow up issue that propose to also let authors count who are indicated by Co-authored-by keyword in commit messages :)