search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.26k stars 5.32k forks source link

External storage (s3) error #30441

Open TristanWasTaken opened 3 months ago

TristanWasTaken commented 3 months ago

Description

I'm using the internal docker hostname as domain in the gitea config (in this case minio-node-1, see log gist for my app.ini config) which throws the error

Endpoint: does not follow ip address or domain name standards

The fix from #27171 (message) (which is the same issue, but was closed without the main issue ever being fixed) of removing sub-sections of storage worked for me.

On a fresh install of Gitea 1.20.0, removing those other sections (attachement, lfs, picture, storage.package) worked.

It should either 1. be documented or fixed by either 2. not validating the domain and/or only check if it resolves or 3. throw a specific error that the sections have to be removed

Gitea Version

1.21.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/TristanWasTaken/4ba82356a03645af1ebc888772a1f2fa

Screenshots

No response

Git Version

No response

Operating System

Docker

How are you running Gitea?

docker gitea/gitea:1.21.3

Database

None

yp05327 commented 3 months ago

I think this is caused by #26441 When the section is [name] only the settings in this section has effect.

lunny commented 3 months ago

Please remove all STORAGE_TYPE = minio from sections except [storage] and try again.

TristanWasTaken commented 3 months ago

Please remove all STORAGE_TYPE = minio from sections except [storage] and try again.

works -> config gist -> log gist

yp05327 commented 3 months ago

maybe we need update docs or more descriptions in app.example.ini

GiteaBot commented 2 months ago

We close issues that need feedback from the author if there were no new comments for a month. :tea:

TristanWasTaken commented 2 months ago

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@lunny -> https://github.com/go-gitea/gitea/issues/30441#issuecomment-2052002049