go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.07k stars 5.49k forks source link

Notifications remains after repository or issue deleted. #3105

Closed lunny closed 5 years ago

lunny commented 6 years ago

image

ethantkoenig commented 6 years ago

I would like to make a friendly observation that we wouldn't have this problem if we used foreign keys.

svarlamov commented 6 years ago

@ethantkoenig I found it really crazy that Gitea doesn't use FKs after digging into the code the last few days... May I ask why this is the case?

lunny commented 6 years ago

@ethantkoenig @svarlamov I didn't implement FK in xorm.