search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.01k stars 5.31k forks source link

Untangle offline mode #31112

Open SuperSandro2000 opened 1 month ago

SuperSandro2000 commented 1 month ago

Description

Right now the situation around the offline mode and federated avatars is a bit of a mess especially after #28548. I've tried to understand the code around it and not noticed, that the offline mode isn't changing anything regarding to CDN but is just used as an override to Disable Gravatar and Enable Federated Avatars. I think it would be a lot less confusing if the offline mode setting would be just removed and the avatar features are controlled directly. Also since GRAVATAR_SOURCE exists, DISABLE_GRAVATAR can also be removed.

Gitea Version

1.22

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

With NixOS ofcourse

Database

PostgreSQL

wxiaoguang commented 1 month ago

Hmm yes, some options on the installation page and in the config file are totally a mess .... I totally agree with you 🤣

They need to be refactored with a new design.

Sharaf5 commented 1 month ago

that option was mainly to disable the cdn and just serve locally I think it's still functional as I really notice no cdn actually Screenshot_20240527_223704

Note : I can't tell whether the code itself need refactoring or not

SuperSandro2000 commented 1 month ago

that option was mainly to disable the cdn and just serve locally

I don't think that functionality exists anymore. I have offline mode turned off and all assets except for LibreAvatar and some extensions are served from Gitea itself.