`Start review` and `Add comment` button should be disabled or need check whether comment is empty

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD

https://gitea.com

MIT License

44.31k stars 5.43k forks source link

`Start review` and `Add comment` button should be disabled or need check whether comment is empty #31303

Open yp05327 opened 3 months ago

yp05327 commented 3 months ago

Description

Reproduce:

leave input box empty, and click Start review (after start review you will only see Add comment) Then you can see one review is added but actually not. Then comment the review you will see this error

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

yp05327 commented 3 months ago

GitHub has this check: the buttons are all disable when input is empty