go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
43.23k stars 5.32k forks source link

Italian alphabet onlyin repo + org names #31345

Open icf20 opened 1 month ago

icf20 commented 1 month ago

Description

Apparently repo and organizations names cant have

ñ, ç, ț, ă, â, ș, î

yes "Gobierno de España" the Spanish government is not allowed to be an organization

image

dont ask to have ñ->n, last time White House did that i went from feliz año to feliz ano

Gitea Version

1,22

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

container

Database

None

silverwind commented 1 month ago

These name limitations are intentional to keep compatibilty with other forges like GitHub etc. See https://github.com/go-gitea/gitea/issues/4150#issuecomment-2142191169 for some recent research on repo/org names. I guess it'd be fine to make this regex configurable but the default must stay compatible with other forges.

delvh commented 1 month ago

I guess it'd be fine to make this regex configurable

Not a good idea. We cannot control what you write into the regex. Why is not being able to validate it a bad idea? Well… the org names must appear on your file system. I have no idea how well OSs like Windows handle certain names. Or even Linux, as special chars in a filename are always a good idea to annoy your server admin to no end. And since we cannot validate the regex, this will lead to hard to understand error messages, and thus pissed off users. So no, I'm not a fan of allowing non-ASCII chars.

silverwind commented 1 month ago

Recent filesystems handle unicode pretty well, but still it's likely better to not let the user unknowingly break the portability of their repos.

lunny commented 1 month ago

I don't support relaxing the limitation except the git file system structure has been changed.