search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.39k stars 5.43k forks source link

Remove the `Delete Branch` confirmation modal from merged pull requests #31503

Open silverwind opened 3 months ago

silverwind commented 3 months ago

Feature Description

I find this modal annoying and it does not match GitHub behaviour where a merged PR branch is deleted in a single click. I think it's always safe to delete such branches, right?

Screenshots

image
delvh commented 3 months ago

I think it's always safe to delete such branches, right?

If this branch is fully contained within the main branch, yes. However, git can't know this when you squash merge or rebase merge.

delvh commented 3 months ago

But yeah, branches that have no commit ahead of them should be deleteable without a modal

lunny commented 1 month ago

Maybe after #6375 resolved.