search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.01k stars 5.4k forks source link

Login form not password manager friendly #31686

Open KN4CK3R opened 1 month ago

KN4CK3R commented 1 month ago

Description

Since #31530 the login form can't be used with external password managers (or simply behaviour driven users) which type {username}[TAB]{password}[ENTER] because the Forgot password? label gets the focus after pressing the tab key.

Screenshots

grafik

silverwind commented 1 month ago

Likely add tabindex="-1" to it.

silverwind commented 1 month ago

https://github.com/go-gitea/gitea/pull/31689

delvh commented 1 month ago

I don't think sacrificing accessibility for this feature is worth it. Why not move the forgot password? below the password entry? That fixes this problem as well without any drawbacks.

silverwind commented 1 month ago

Why not move the forgot password? below the password entry?

Imho it looks better the way it is and others like GitHub and IMDB do agree on this design as well.

I don't think sacrificing accessibility for this feature is worth it.

I would say a tabindex change even improves accessibility because the user tabs through elements in a more natural order.