search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.86k stars 5.48k forks source link

Gitea service panics when attempting to clone/pull #32367

Open eeyrjmr opened 3 days ago

eeyrjmr commented 3 days ago

Description

upon upgrading to gitea-1.22.3 (from 1.22.2) on windows, any clone/pull via git results in a 500 error. The WebUI "mostly" still functions but does slow down. Closer examination of the logs shows a panic

2024/10/29 10:34:07 ...rs/common/errpage.go:26:RenderPanicErrorPage() [E] PANIC: runtime error: invalid memory address or nil pointer dereference

since this was a MINOR bump, the service was "downgraded" to 1.22.2. gitea-1.22.3-windows-4.0-amd64.exe and gitea-1.22.3-gogit-windows-4.0-amd64.exe were both tried and both exhibit the same issue

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://gist.github.com/eeyrjmr/a4eb1e5e159a71fc6152210fb030f2c3

Screenshots

No response

Git Version

2.46.1

Operating System

Windows

How are you running Gitea?

Windows service

Database

MySQL/MariaDB

wxiaoguang commented 3 days ago 
/source/services/auth/source/oauth2/token.go:45 (0x200bbce)
/source/services/auth/source/oauth2/token.go:44 (0x200baad)
/source/services/auth/oauth2.go:34 (0x203940d)
/source/services/auth/basic.go:80 (0x2037264)

Regression of Don't init singing keys if oauth2 provider disabled (#32177)

eeyrjmr commented 3 days ago

I can confirm that Oauth is disabled. This was done for an odd issue and I meant to raise a PR on that but I honestly forgot

The issue was a RESTRICTED user would have a js overlay about Oauth if it was enabled. This might have been fixed so I can recheck and if it is still an issue open a separate PR